Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: adjust code sample for stream.finished #29983

Closed
wants to merge 1 commit into from
Closed

doc: adjust code sample for stream.finished #29983

wants to merge 1 commit into from

Conversation

imcotton
Copy link
Contributor

To avoid confusion on stream.finished being accepting rest params of readable streams.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Oct 15, 2019
@Trott
Copy link
Member

Trott commented Oct 15, 2019

@nodejs/streams

Fishrock123
Fishrock123 approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this is more consistent with the example code above.

@trivikr
Copy link
Member

trivikr commented Oct 16, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3995/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2019
targos pushed a commit that referenced this pull request Oct 27, 2019
@imcotton @targos
doc: adjust code sample for stream.finished
f185990 
PR-URL: #29983
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos
Copy link
Member

targos commented Oct 27, 2019

Landed in f185990

@targos targos closed this Oct 27, 2019
targos pushed a commit that referenced this pull request Oct 28, 2019
@imcotton @targos
doc: adjust code sample for stream.finished
3c23224 
PR-URL: #29983
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@imcotton @targos
doc: adjust code sample for stream.finished
2b1b7a6 
PR-URL: #29983
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@imcotton @targos
doc: adjust code sample for stream.finished
6dd3e67 
PR-URL: #29983
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@imcotton @targos
doc: adjust code sample for stream.finished
e9d75d6 
PR-URL: #29983
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@imcotton @targos
doc: adjust code sample for stream.finished
c2108d4 
PR-URL: #29983
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@aks- aks- aks- approved these changes

@lpinca lpinca lpinca approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@imcotton @Trott @trivikr @targos @jasnell @Fishrock123 @lpinca @aks- @nodejs-github-bot